Codecov Report

Attention: Patch coverage is 68.84058% with 43 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (4c47024) to head (1a1a647).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main    #5015      +/-   ##
==========================================
- Coverage   78.41%   78.33%   -0.09%     
==========================================
  Files         329      333       +4     
  Lines       15494    15632     +138     
  Branches     3579     3603      +24     
==========================================
+ Hits        12150    12245      +95     
- Misses       3344     3387      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Team delete needs to also remove all 3rd party broker creds and shut down any mqtt-schema-agents that might be running.

container driver needs to look at DB on startup and restart any missing mqtt-schema-agents

Should be enough to start the UI work to create/edit these

Some api tweaks as discussed:

/api/v1/teams/:teamId/broker/credentials -> /api/v1/teams/:teamId/brokers

• GET lists brokers
• POST adds new broker

/api/v1/teams/:teamId/broker/:brokerId -> /api/v1/teams/:teamId/brokers/:brokerId

• GET/PUT/DELETE - operations on individual broker creds object

/api/v1/teams/:teamId/broker/:brokerId -> /api/v1/teams/:teamId/brokers/:brokerId

• GET/PUT/DELETE - operations on individual broker object

/api/v1/teams/:teamId/broker/:brokerId/credentials -> /api/v1/teams/:teamId/brokers/:brokerId/credentials

• Agent only api for retrieving creds

Team Broker

/api/v1/teams/:teamId/brokers/team - team is the magic id of the built-in team broker

Topics info

/api/v1/teams/:teamId/broker/:brokerId/topics or /schema or whatever is appropriate...

@knolleary renaming done.

Still can't get codecov to show me what's missing, I think you now need to create an account even for the opensource/free access.

For the POST the body needs to looks like

{
  name: { type: 'string' },
  host: { type: 'string' },
  port: { type: 'number' }, // default 1883
  protocol: { type: 'string' }, // mqtt: or ws:
  protocolVersion: { type: 'number' }, // this should be 3, 4 or 5 picked from a list of 3.0, 3.1, 5 (with 3.1 as the default)
  ssl: { type: 'boolean' }, // default false
  verifySSL: { type: 'boolean' }, // default true
  clientId: { type: 'string' },
  credentials: {
    type: 'object' // MVP keys of strings, username and password
  }
}